Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add model freshness for adaptive job #11170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add model freshness for adaptive job #11170

wants to merge 2 commits into from
+194 −3

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Dec 19, 2024 •
edited
Loading

Resolves #11123

This patch added parsing logic for the model freshness config required for adaptive job

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@ChenyuLInx ChenyuLInx added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Dec 19, 2024
@ChenyuLInx ChenyuLInx requested review from a team as code owners December 19, 2024 01:08
@ChenyuLInx ChenyuLInx requested review from vadim82 and removed request for a team December 19, 2024 01:08
@cla-bot cla-bot bot added the cla:yes label Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (f2222d2) to head (0c96f71).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11170      +/-   ##
==========================================
- Coverage   88.93%   88.88%   -0.05%     
==========================================
  Files         187      186       -1     
  Lines       24057    24073      +16     
==========================================
+ Hits        21395    21398       +3     
- Misses       2662     2675      +13
Flag Coverage Δ
integration 86.20% <100.00%> (-0.11%) ⬇️
unit 62.08% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.08% <100.00%> (+0.02%) ⬆️
Integration Tests 86.20% <100.00%> (-0.11%) ⬇️

@ChenyuLInx ChenyuLInx closed this Dec 19, 2024
@ChenyuLInx ChenyuLInx force-pushed the cl/add_model_freshness_def branch from 589b391 to f2222d2 Compare December 19, 2024 20:03
@ChenyuLInx ChenyuLInx reopened this Dec 19, 2024
@ChenyuLInx ChenyuLInx mentioned this pull request Dec 19, 2024
Open
@ChenyuLInx ChenyuLInx force-pushed the cl/add_model_freshness_def branch from 4c388e4 to 0c96f71 Compare December 19, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadim82 vadim82 Awaiting requested review from vadim82 vadim82 is a code owner automatically assigned from dbt-labs/cloud-artifacts

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Adaptive Job] Add freshness spec to model
1 participant
@ChenyuLInx